code-423n4 / 2023-01-biconomy-findings

10 stars 10 forks source link

EIP-1967 has been wrongly implemented. #351

Closed code423n4 closed 1 year ago

code423n4 commented 1 year ago

Lines of code

https://github.com/code-423n4/2023-01-biconomy/blob/main/scw-contracts/contracts/smart-contract-wallet/Proxy.sol#L1

Vulnerability details

Impact

The availability of the protocol will be impacted since tool like etherscan will not be able to find the implementation and their for correctly show the source code of the contract.

Tools Used

Visual Studio Code

Recommended Mitigation Steps

Remediation: Use the correct implementation of the EIP-1967 Sample implementation from openzeppelin can be found ERC1967Upgrade.sol

c4-judge commented 1 year ago

gzeon-c4 marked the issue as unsatisfactory: Insufficient quality