code-423n4 / 2023-01-biconomy-findings

12 stars 10 forks source link

SmartAccount.sol Inherit from ISignatureValidatorConstants instead of ISignatureValidator #451

Closed code423n4 closed 1 year ago

code423n4 commented 1 year ago

Lines of code

https://github.com/code-423n4/2023-01-biconomy/blob/main/scw-contracts/contracts/smart-contract-wallet/SmartAccount.sol#L25

Vulnerability details

Impact

Importing the wrong Interface can lead to unexpected behaviors in the protocol.

Proof of Concept

https://github.com/code-423n4/2023-01-biconomy/blob/main/scw-contracts/contracts/smart-contract-wallet/SmartAccount.sol#L25

Tools Used

Manual

Recommended Mitigation Steps

Consider importing the right interface.

c4-judge commented 1 year ago

gzeon-c4 marked the issue as unsatisfactory: Insufficient quality