code-423n4 / 2023-01-biconomy-findings

12 stars 10 forks source link

IEntryPoint is used in SmartAccount contract but not imported #478

Closed code423n4 closed 1 year ago

code423n4 commented 1 year ago

Lines of code

https://github.com/code-423n4/2023-01-biconomy/blob/main/scw-contracts/contracts/smart-contract-wallet/SmartAccount.sol#L59

Vulnerability details

Impact

This can potentially break the code of a lot of the functions associated with it in the smartAccount contract.

Proof of Concept

https://github.com/code-423n4/2023-01-biconomy/blob/main/scw-contracts/contracts/smart-contract-wallet/SmartAccount.sol#L59

Tools Used

Manual

Recommended Mitigation Steps

import contracts/smart-contract-wallet/aa-4337/interfaces/IEntryPoint.sol

c4-judge commented 1 year ago

gzeon-c4 marked the issue as unsatisfactory: Invalid