search

code-423n4 / 2023-01-biconomy-findings

10 stars 11 forks source link

Lack of Zero Address Signer Validation #519

Closed code423n4 closed 1 year ago

code423n4 commented 1 year ago

Lines of code

https://github.com/code-423n4/2023-01-biconomy/blob/main/scw-contracts/contracts/smart-contract-wallet/SmartAccountFactory.sol#L349-L352

Vulnerability details

Signer should be checked to not equal the zero address otherwise an invalid signature could pass validation.

c4-judge commented 1 year ago

gzeon-c4 marked the issue as unsatisfactory: Insufficient quality

livingrockrises commented 1 year ago

lines of code are misleading.

c4-sponsor commented 1 year ago

livingrockrises marked the issue as sponsor disputed