search

code-423n4 / 2023-01-drips-findings

0 stars 2 forks source link

No reentrancy guard on safeMint() function that has a callback #116

Closed code423n4 closed 1 year ago

code423n4 commented 1 year ago

Lines of code

https://github.com/code-423n4/2023-01-drips/blob/main/src/NFTDriver.sol#L79

Vulnerability details

Impact

In NFTDriver.sol, the safeMint() function calls _safeMint() which has a callback to the "to" address argument. Functions with callbacks should have reentrancy guards in place for protection against possible malicious actors..

Proof of Concept

https://github.com/code-423n4/2023-01-drips/blob/main/src/NFTDriver.sol#L79

Tools Used

Manual code review

Recommended Mitigation Steps

Add a reentrancy guard modifier on the safeMint() function.

c4-judge commented 1 year ago

GalloDaSballo marked the issue as unsatisfactory: Invalid

GalloDaSballo commented 1 year ago

Lacks of an attack, the last call is just for events