search

code-423n4 / 2023-01-drips-findings

0 stars 2 forks source link

QA Report #221

Open code423n4 opened 1 year ago

code423n4 commented 1 year ago

See the markdown file with the details of this report here.

GalloDaSballo commented 1 year ago

NC00 driverId offset is hardcoded in the driver contracts R

NC01 Wrong and confusing naming of variable in AddressDriver.t.sol Disputing due to test file

NC02 Unit tests are missing comments Saem

L01 Incomplete/missing NatSpec tags in function comments NC

L02 Extensive usage of slither-disable, posing a risk, and also causing source code deterioration Disputing in lack of specific example

L03 DOS condition when registering type(uint32).max number of drivers R, don't think it's a realistic risk

L04 Wrong and misleading comment in DripsHub.sol R

L05 DOS condition when adding max amount of tokens to drips balance L

L06 Wrong and misleading comment, plus possible risk for future code changes NC

L07 Bad english in comment in DripsHub.sol, can be misleading NC

L08 Certain ERC20 tokens like UNI and COMP are not compatible with the AddressDriver contract L

L09 Wrong parameter name used for NatSpec tag in function comment NC

L10 Wrong NatSpec tag used in function comment NC

GalloDaSballo commented 1 year ago

2L 3R 5NC

c4-judge commented 1 year ago

GalloDaSballo marked the issue as grade-b