search

code-423n4 / 2023-01-drips-findings

0 stars 2 forks source link

QA Report #244

Open code423n4 opened 1 year ago

code423n4 commented 1 year ago

See the markdown file with the details of this report here.

GalloDaSballo commented 1 year ago

1 Comment is wrong

L

2 _balanceAt function name shadowing

R

3 Store magic numbers in constants

R

4 NFTDriver.sol is missing tokenUri function to return erc721 metadata.

R

5 DripsHub says cyclesSecs must be above 1, but there is no condition checking it

L

6 finalAmtPerCycle sounds like average naming it finalCycleAmt would be more appropriate

R

7 Protocol design is not optimal for funds withdrawal

R

2L 5R

c4-judge commented 1 year ago

GalloDaSballo marked the issue as grade-b