code-423n4 / 2023-01-drips-findings

0 stars 2 forks source link

QA Report #252

Closed code423n4 closed 1 year ago

code423n4 commented 1 year ago

See the markdown file with the details of this report here.

GalloDaSballo commented 1 year ago

[N-01] NATSPEC COMMENTS SHOULD BE INCREASED IN CONTRACTS NC

[N-02] NON-LIBRARY/INTERFACE FILES SHOULD USE FIXED COMPILER VERSIONS, NOT FLOATING ONES NC

[N-03] PRAGMA VERSION^0.8.17 VERSION TOO RECENT TO BE TRUSTED. Disputing

[N-04] No use of upgradeable OpenZeppelin contract R

[N-05] CRITICAL ADDRESS CHANGES SHOULD USE TWO-STEP PROCEDURE NC

[N-06] USE OF BYTES.CONCAT() INSTEAD OF ABI.ENCODEPACKED(,) NC

[L-01] DRAFT OPENZEPPELIN DEPENDENCIES R

2R 4NC

c4-judge commented 1 year ago

GalloDaSballo marked the issue as grade-c