search

code-423n4 / 2023-01-drips-findings

0 stars 2 forks source link

QA Report #300

Closed code423n4 closed 1 year ago

code423n4 commented 1 year ago

See the markdown file with the details of this report here.

GalloDaSballo commented 1 year ago

1. MISSING address(0) CHECKS FOR THE FOLLOWING ADDRESS INPUTS TO THE CONSTRUCTORS AND FUNCTIONS.

L

2. REENTRANCY IN setDrips FUNCTION FOR ERC777 TOKENS

OOS

3. USE safeApprove FUNCTION TO APPROVE TOKENS BEFORE safeTransferFrom FUNCTION IS CALLED.

Invalid, caller must approve before calling that's not unusual

4. IMMUTABLE VARIABLES SHOULD BE ASSIGNED VALUES INSIDE THE CONSTRUCTOR.

Disputing in lack of inconsistency, the sponsor wants to use immutable for keccak

5. NO NEED TO CALL THE INHERITED CONTRACT FUNCTIONS USING THE CONTRACT'S PUBLIC API

NC

6. IN THE DEFINITION OF THE DRIPS CONFIGURATION THE LAST 32 BITS ARE CONSIDERED AS DRIPS DURATION. BUT THE LOGIC IMPLEMENTATION DEFINES THE LAST 32 BITS AS THE END TIME.

L

2L 1NC

c4-judge commented 1 year ago

GalloDaSballo marked the issue as grade-c