code-423n4 / 2023-01-drips-findings

0 stars 2 forks source link

QA Report #302

Closed code423n4 closed 1 year ago

code423n4 commented 1 year ago

See the markdown file with the details of this report here.

GalloDaSballo commented 1 year ago

L-1 CRITICAL CHANGES SHOULD USE TWO-STEP PROCEDURE NC

L-2 DRAFT OPENZEPPELIN DEPENDENCIES R

L-3 LOSS OF PRECISION DUE TO ROUNDING L

L-4 Block values as a proxy for time Disputed - 3

L-5 Unspecific compiler version pragma NC

NC-1 INSUFFICIENT COVERAGE NC

NC-2 ADD A TIMELOCK TO CRITICAL FUNCTIONS Didpusting

NC-3 USE OF BYTES.CONCAT() INSTEAD OF ABI.ENCODEPACKED(,) NC

NC-4 NATSPEC COMMENTS SHOULD BE INCREASED IN CONTRACTS NC

NC-5 Omissions in events NC

NC-6 PRAGMA VERSION^0.8.17 VERSION TOO RECENT TO BE TRUSTED Disputing for lack of evidence

NC-7 For functions, follow solidity standard naming conventions NC

NC-8 Lines are too long NC

NC-9 NOT VERIFIED INPUT L

2L 1R 8NC

c4-judge commented 1 year ago

GalloDaSballo marked the issue as grade-c