code423n4 commented 1 year ago

Lines of code

https://github.com/code-423n4/2023-01-drips/blob/main/src/Drips.sol#L716 https://github.com/code-423n4/2023-01-drips/blob/main/src/Drips.sol#L882

Vulnerability details

Impact

Use of Boolean constants (true/false) in code is indicative of flawed logic.

Boolean constants in code have only a few legitimate uses. Other uses (in complex expressions, as conditionals) indicate either an error or, most likely, the persistence of faulty code.

Proof of Concept

File: Drips.sol

716:             while (true) {

882:         while (true) {

Tools Used

VS Code

Recommended Mitigation Steps

Verify and simplify the condition.

c4-judge commented 1 year ago

GalloDaSballo marked the issue as unsatisfactory: Insufficient proof

GalloDaSballo commented 1 year ago

This is not sufficient, you must detail a vulnerability

code-423n4 / 2023-01-drips-findings