search

code-423n4 / 2023-01-drips-findings

0 stars 2 forks source link

QA Report #321

Closed code423n4 closed 1 year ago

code423n4 commented 1 year ago

See the markdown file with the details of this report here.

CodeSandwich commented 1 year ago

[dispute validity] It's fine and it's addressed in _addDelta:

// Any over- or under-flows are fine, they're guaranteed to be fixed by a matching
// under- or over-flow from the other call to `_addDelta` made by `_addDeltaRange`.
// This is because the total balance of `Drips` can never exceed `type(int128).max`,
// so in the end no amtDelta can have delta higher than `type(int128).max`.
c4-judge commented 1 year ago

GalloDaSballo marked the issue as grade-c