search

code-423n4 / 2023-01-drips-findings

0 stars 2 forks source link

QA Report #324

Open code423n4 opened 1 year ago

code423n4 commented 1 year ago

See the markdown file with the details of this report here.

GalloDaSballo commented 1 year ago

1 Missing checks for address(0x0) when assigning values to address state or immutable variables L

2 block.timestamp used as time proxy Disputed - 3

3 Destination recipient for assets may be address(0) L

4 Upgradeable contract is missing a __gap[50] storage variable to allow for new storage variables in later versions L

5 _safeMint() should be used rather than _mint() wherever possible L

1 Use of deprecated draft file R

2 Constants should be defined rather than using magic numbers R

3 Max value can be used rather than 2 ** n R

4 Omissions in events NC

5 Missing initializer modifier on constructor R

6 No need to return void in a constructor NC

4L 4R 2NC -3

c4-judge commented 1 year ago

GalloDaSballo marked the issue as grade-b