code-423n4 / 2023-01-drips-findings

0 stars 2 forks source link

Upgraded Q -> 3 from #213 [1677236903539] #325

Closed c4-judge closed 1 year ago

c4-judge commented 1 year ago

Judge has assessed an item in Issue #213 as 3 risk. The relevant finding follows:

At ImmutableSplitsDriver if user sends to himself the funds will be stuck forever Not sure to what extent the protocol needs to protect users from dumb mistakes, but it might be worth adding a check at ImmutableSplitsDriver.createSplits() that the user isn't sending to himself, since in that case there will always be some funds that will be stuck in the user's splittable balance.

c4-judge commented 1 year ago

GalloDaSballo marked the issue as duplicate of #150

c4-judge commented 1 year ago

GalloDaSballo marked the issue as partial-25

c4-judge commented 1 year ago

This auto-generated issue was withdrawn by GalloDaSballo