search

code-423n4 / 2023-01-drips-findings

0 stars 2 forks source link

QA Report #89

Closed code423n4 closed 1 year ago

code423n4 commented 1 year ago

See the markdown file with the details of this report here.

GalloDaSballo commented 1 year ago

[L01] Missing checks for address(0x0) when assigning values to address state variables

L

[L02] approve should be replaced with safeApprove or safeIncreaseAllowance() / safeDecreaseAllowance()

Disputing

[L03] _safeMint() should be used rather than _mint() wherever possible

L

[L04] Unspecific Compiler Version Pragma

NC

[L05] MISSING EVENT FOR CRITICAL PARAMETERS INIT AND CHANGE

NC

[N01] Adding a return statement when the function defines a named return variable, is redundant

R

[N02] constants should be defined rather than using magic numbers

R

[N03] NC-library/interface files should use fixed compiler versions, not floating ones

NC

[N04] USE OF BYTES.CONCAT() INSTEAD OF ABI.ENCODEPACKED()

NC

[N05] PRAGMA VERSION^0.8.17 VERSION TOO RECENT TO BE TRUSTED.

Disputing

[N06] SHOWING THE ACTUAL VALUES OF NUMBERS IN NATSPEC COMMENTS MAKES CHECKING AND READING CODE EASIER

Unclear disputing

2L 2R 4NC

c4-judge commented 1 year ago

GalloDaSballo marked the issue as grade-c