GalloDaSballo
commented
1 year ago | LOW‑1 | Add to blacklist function | 1 | Disputing
| LOW‑2 | Draft Import Dependencies | 1 | R
| LOW‑3 | Possible rounding issue | 7 | Disputing due to lack of detail
| LOW‑4 | Use _safeMint instead of _mint | 1 | L
| LOW‑5 | Missing Checks for Address(0x0) | 2 | L
| LOW‑6 | Contracts are not using their OZ Upgradeable counterparts | 16 | Disputing
| LOW‑7 | Remove unused code | 2 | Invalid, contract is a library - 3
| NC‑1 | Add a timelock to critical functions | 7 | Disputing
| NC‑2 | Avoid Floating Pragmas: The Version Should Be Locked | 8 | NC
| NC‑3 | Critical Changes Should Use Two-step Procedure | 1 | NC
| NC‑4 | Function writing that does not comply with the Solidity Style Guide | 8 | NC
| NC‑5 | Use delete to Clear Variables | 2 | Disputing
| NC‑6 | Imports can be grouped together | 16 | NC
| NC‑7 | NatSpec return parameters should be included in contracts | 1 | NC
| NC‑8 | No need to initialize uints to zero | 9 | NC
| NC‑9 | Missing event for critical parameter change | 4 | Invalid, events are emitted
| NC‑10 | Implementation contract may not be initialized | 8 | Invalid / Off
| NC‑11 | NatSpec comments should be increased in contracts | 1 | NC
| NC‑12 | Use bytes.concat() | 1 | NC
| NC‑13 | Use of Block.Timestamp | 1 | Invalid, penalizing - 3
2L 1R 8NC - 6
c4-judge
See the markdown file with the details of this report here.