search

code-423n4 / 2023-01-numoen-findings

0 stars 0 forks source link

Possible Vulnerabilities #215

Closed code423n4 closed 1 year ago

code423n4 commented 1 year ago

Lines of code

https://github.com/code-423n4/2023-01-numoen/blob/2ad9a73d793ea23a25a381faadc86ae0c8cb5913/src/core/Lendgine.sol#L78

Vulnerability details

Impact

Detailed description of the impact of this finding.

  1. Reentrancy: The "nonReentrant" modifier is used in functions to prevent reentrancy, but it is recommended to use a mutex mechanism to lock the contract during critical operations.
  2. Integer Overflow/Underflow: No checks are made to ensure the absence of overflow or underflow in arithmetic operations.
  3. Transfer of untrusted data: The contract accepts untrusted data from external calls such as "mint" and "deposit". This data can be malicious and can potentially compromise the contract.
  4. Unchecked return values: Some functions, such as "SafeTransferLib.safeTransfer", are used in the code without checking the return values which can cause unexpected behavior.
c4-judge commented 1 year ago

berndartmueller marked the issue as unsatisfactory: Invalid