code-423n4 / 2023-01-numoen-findings

0 stars 0 forks source link

Mint function should have a pause #265

Closed code423n4 closed 1 year ago

code423n4 commented 1 year ago

Lines of code

https://github.com/code-423n4/2023-01-numoen/blob/2ad9a73d793ea23a25a381faadc86ae0c8cb5913/src/core/Lendgine.sol#L71-L102

Vulnerability details

Impact

Even if a market is paused due to insolvency/bugs, there will still be minting going on. This leaves no protection against mining in such case.

Tools Used

VS code

Recommended Mitigation Steps

Check in function mint that the market is not paused. For further reading: https://blog.logrocket.com/pause-functionality-secure-solidity-smart-contracts/

c4-judge commented 1 year ago

berndartmueller marked the issue as unsatisfactory: Invalid