search

code-423n4 / 2023-01-ondo-findings

0 stars 0 forks source link

Upgradeable #347

Closed code423n4 closed 1 year ago

code423n4 commented 1 year ago

Lines of code

https://github.com/code-423n4/2023-01-ondo/blob/f3426e5b6b4561e09460b2e6471eb694efdd6c70/contracts/lending/OndoPriceOracle.sol#L16

Vulnerability details

Impact

Since the contract OndoPriceOracle.sol is a critical contract it should have room to be upgrade, either use the library @openzeppelin/contracts-upgradeable or leave a storage gap. An example of this would be to add this line: uint256[50] private __gap;

Proof of Concept

Provide direct links to all referenced code in GitHub. Add screenshots, logs, or any other relevant proof that illustrates the concept. I recommend this resource for further reading https://docs.openzeppelin.com/contracts/4.x/upgradeable#storage_gaps

Tools Used

None

c4-judge commented 1 year ago

trust1995 marked the issue as unsatisfactory: Out of scope