code-423n4 / 2023-01-opensea-findings

0 stars 0 forks source link

Gas Optimizations #105

Closed code423n4 closed 1 year ago

code423n4 commented 1 year ago

See the markdown file with the details of this report here.

HickupHH3 commented 1 year ago

G-1 is acceptable, G-2 isn't because of the return value. Prefix returns value after increment, postfix before.

HickupHH3 commented 1 year ago

5 gas per iteration for the sole G-1 finding. While the report is appreciated, the gas savings aren’t substantial enough to warrant a satisfactory grade.

c4-judge commented 1 year ago

HickupHH3 marked the issue as grade-c