search

code-423n4 / 2023-01-opensea-findings

0 stars 0 forks source link

Gas Optimizations #116

Closed code423n4 closed 1 year ago

code423n4 commented 1 year ago

See the markdown file with the details of this report here.

HickupHH3 commented 1 year ago

I get the optimization, but more effort could have been put in to explain how exactly to "use Shift Right/Left".

c4-judge commented 1 year ago

HickupHH3 marked the issue as grade-c

HickupHH3 commented 1 year ago

Eg.

- terminalMemoryOffset = (totalOrders + 1) * 32;
+ terminalMemoryOffset = (totalOrders + 1) << 5;

Nevertheless, I prefer the way it is for readability.