search

code-423n4 / 2023-01-opensea-findings

0 stars 0 forks source link

QA Report #118

Closed code423n4 closed 1 year ago

code423n4 commented 1 year ago

See the markdown file with the details of this report here.

HickupHH3 commented 1 year ago

block.timestamp used as time proxy - Disagree. See #4 Undocumented parameters / Missing Natspec - NC Include return parameters in natspec comments - NC Missing spacing in operator - NC Naming convention of non constants / Naming convention of constants - NC

Total: 4 NCs = 4pts, fails to meet cutoff of 5 pts.

c4-judge commented 1 year ago

HickupHH3 marked the issue as grade-c