Closed code423n4 closed 1 year ago
Unsatisfactory. Mainly 2 issues reported: 1) When a variable is only used once, it could save gas by not creating the variable and using the operation directly inside where it is needed. 2) Instead of variable-- it is less expensive to do unchecked{--variable;}
The 1st is usually for readability purposes. For the 2nd, effort could have been put in to explicitly state what the variable was.
Submissions against any in-scope contract are always welcome if they improve readability and comprehension without sacrificing on safety or (in the core Seaport contract) efficiency.
HickupHH3 marked the issue as grade-c
See the markdown file with the details of this report here.