search

code-423n4 / 2023-01-opensea-findings

0 stars 0 forks source link

Incorrect use of msg.sender in isApprovedForAll function causes issues #62

Closed code423n4 closed 1 year ago

code423n4 commented 1 year ago

Lines of code

https://github.com/ProjectOpenSea/opensea-creatures/blob/165d4fe6a90532a7a913b76ef33bfbfc9624c878/contracts/ERC721Tradable.sol#L89

Vulnerability details

Impact

the function isApprovedForAll(address owner, address operator) is using msg.sender as the address of the user instead of the address that is passed as the owner parameter, this might cause some issues on the code.

0age commented 1 year ago

this is against the wrong repo!

HickupHH3 commented 1 year ago

HAHAHA

c4-judge commented 1 year ago

HickupHH3 marked the issue as unsatisfactory: Out of scope