QA Report

[code423n4]

See the markdown file with the details of this report here.

[HickupHH3]

01 - Invalid. Said missing check is performed:

assembly {
  // route 0 and 1 are payable, otherwise route is not payable.
  correctPayableStatus := eq(
      additionalRecipientsItemType,
      iszero(callvalue())
  )
}

// Revert if msg.value has not been supplied as part of payable
// routes or has been supplied as part of non-payable routes.
if (!correctPayableStatus) {
  _revertInvalidMsgValue(msg.value);
}

02 - Lacking sufficient justification on why the downcasts are unsafe. NC
 03 - NC
 04 - NC
 05 - R
 06 - NC 07 - NC 
08 - R
 
09 - NC 

10 - NC 


11 - NC

[HickupHH3]

8 NCs + 2 Rs = 12 pts

[HickupHH3]

Potentially grade A once moderation is applied.

[c4-judge]

HickupHH3 marked the issue as grade-a