search

code-423n4 / 2023-01-opensea-findings

0 stars 0 forks source link

Gas Optimizations #72

Closed code423n4 closed 1 year ago

code423n4 commented 1 year ago

See the markdown file with the details of this report here.

HickupHH3 commented 1 year ago

Unsatisfactory for not filtering false positives (Eg. the 2nd issue's PointerLibraries reference)

/// @dev Reads the uint8 at `cdPtr` in calldata.
    function readUint8(
        CalldataPointer cdPtr
    ) internal pure returns (uint8 value) {
        assembly {
            value := calldataload(cdPtr)
        }
    }

It's the purpose of the function to return uint8.

c4-judge commented 1 year ago

HickupHH3 marked the issue as grade-c