search

code-423n4 / 2023-01-opensea-findings

0 stars 0 forks source link

Yul 'staticcall' return value not checked #77

Closed code423n4 closed 1 year ago

code423n4 commented 1 year ago

Lines of code

https://github.com/ProjectOpenSea/seaport/blob/5de7302bc773d9821ba4759e47fc981680911ea0/contracts/lib/SignatureVerification.sol#L120

Vulnerability details

Impact

Unexpected behavior if call fail.

0age commented 1 year ago

contested; explained in the comment right above the linked line

                    // Attempt to recover the signer for the given signature. Do
                    // not check the call status as ecrecover will return a null
                    // address if the signature is invalid.
c4-judge commented 1 year ago

HickupHH3 marked the issue as unsatisfactory: Invalid