search

code-423n4 / 2023-01-opensea-findings

0 stars 0 forks source link

QA Report #78

Open code423n4 opened 1 year ago

code423n4 commented 1 year ago

See the markdown file with the details of this report here.

0age commented 1 year ago

This is a high-quality QA report 👍

HickupHH3 commented 1 year ago

8 NCs, but I think they provide more value than the other QA reports I've come across thus far. Hence, it's worthy of an A grade (+bonus from sponsor for flagging it as high-quality).

c4-judge commented 1 year ago

HickupHH3 marked the issue as grade-a

c4-judge commented 1 year ago

HickupHH3 marked the issue as selected for report

liveactionllama commented 1 year ago

Per discussion with @0age - including the following mitigation links:

[N-01] Replace "ETH" with "Native token": https://github.com/ProjectOpenSea/seaport/pull/921

[N-02] Extract or use named constants: https://github.com/ProjectOpenSea/seaport/pull/922

[N-03] Fragile check for contract order type: https://github.com/ProjectOpenSea/seaport/pull/922

[N-04] Inconsistent use of hex vs. decimal values: https://github.com/ProjectOpenSea/seaport/pull/922

[N-05] Custom comment typos: https://github.com/ProjectOpenSea/seaport/pull/924

[N-06] AlmostOneWord is confusing: https://github.com/ProjectOpenSea/seaport/pull/923

[N-07] Typos in comments: https://github.com/ProjectOpenSea/seaport/pull/924

[N-08] Duplicated constants: https://github.com/ProjectOpenSea/seaport/pull/922