Open code423n4 opened 1 year ago
HickupHH3 marked the issue as grade-a
HickupHH3 marked the issue as grade-b
Downgraded because of failure to filter false positives. Examples:
[G‑04] Add unchecked {} for subtractions where the operands cannot underflow because of a previous require() or if-statement
Already unchecked.
if (nativeTokensRemaining > amount) {
// Skip underflow check as nativeTokensRemaining > amount.
unchecked {
// Transfer remaining native tokens to the caller.
_transferNativeTokens(
payable(msg.sender),
nativeTokensRemaining - amount
);
}
}
[G‑06] internal functions not called by the contract should be removed to save deployment gas
Referenced functions are called in higher order function
HickupHH3 marked the issue as grade-a
Moderation applied, bumped back up to grade A
See the markdown file with the details of this report here.