Upgraded Q -> 2 from #823 [1677594201547]

[c4-judge]

Judge has assessed an item in Issue #823 as 2 risk. The relevant finding follows:

[L-01] Low level call result not correctly checked

https://github.com/code-423n4/2023-01-popcorn/blob/36477d96788791ff07a1ba40d0c726fb39bf05ec/src/vault/VaultController.sol#L238

The last adminProxy.execute is not checked for success.

function __deployAdapter( DeploymentArgs memory adapterData, bytes memory baseAdapterData, IDeploymentController _deploymentController ) internal returns (address adapter) { (bool success, bytes memory returnData) = adminProxy.execute( address(_deploymentController), abi.encodeWithSelector(DEPLOY_SIG, ADAPTER, adapterData.id, _encodeAdapterData(adapterData, baseAdapterData)) ); if (!success) revert UnderlyingError(returnData);

adapter = abi.decode(returnData, (address));

adminProxy.execute(adapter, abi.encodeWithSelector(IAdapter.setPerformanceFee.selector, performanceFee)); // call result not checked

}

[c4-judge]

dmvt marked the issue as duplicate of #541

[c4-judge]

dmvt marked the issue as partial-50

[c4-judge]

dmvt marked the issue as not a duplicate

[c4-judge]

dmvt marked the issue as unsatisfactory: Invalid