search

code-423n4 / 2023-01-popcorn-findings

0 stars 0 forks source link

Upgraded Q -> 2 from #625 [1677633526031] #848

Closed c4-judge closed 1 year ago

c4-judge commented 1 year ago

Judge has assessed an item in Issue #625 as 2 risk. The relevant finding follows:

4) lastHarvest variable inside AdapterBase will never be updated after a successful harvest,this will create big problems related to all the harvest function inside AdapterBase by making this function unusable,in fact only the first harvest will work and the following ones wont,can resolve this problem by updating lastHarvest = block.timestamp after successfull harvest https://github.com/code-423n4/2023-01-popcorn/blob/d95fc31449c260901811196d617366d6352258cd/src/vault/adapter/abstracts/AdapterBase.sol#L441

c4-judge commented 1 year ago

dmvt marked the issue as duplicate of #558

c4-judge commented 1 year ago

dmvt marked the issue as partial-25