code-423n4 / 2023-01-rabbithole-findings

1 stars 2 forks source link

Upgraded Q -> 2 from #206 [1676531414343] #704

Closed c4-judge closed 1 year ago

c4-judge commented 1 year ago

Judge has assessed an item in Issue #206 as 2 risk. The relevant finding follows:

Issue 2: receipts are not burned upon claiming reward.

In my opinion, current system of just claiming some tokens to be "used" has some downsides:

in any claim check, users spend gas to iterate over these tokens too etc. there are two loops in only claim function that checks every token of user

c4-judge commented 1 year ago

kirk-baird marked the issue as duplicate of #119

c4-judge commented 1 year ago

kirk-baird marked the issue as partial-50

c4-judge commented 1 year ago

kirk-baird marked the issue as not a duplicate

c4-judge commented 1 year ago

kirk-baird marked the issue as duplicate of #552

c4-judge commented 1 year ago

kirk-baird marked the issue as partial-50