search

code-423n4 / 2023-01-reserve-findings

4 stars 2 forks source link

Centralization risk: contract have a single point of control #37

Closed code423n4 closed 1 year ago

code423n4 commented 1 year ago

Lines of code

https://github.com/reserve-protocol/protocol/blob/df7ecadc2bae74244ace5e8b39e94bc992903158/contracts/plugins/mocks/EasyAuction.sol#L129

Vulnerability details

Impact

Centralization risks are weaknesses that malevolent project creators as well as hostile outside attackers can take advantage of. They may be used in several forms of attacks, including rug pulls and infinite minting vulnerabilities.

Proof of Concept

Finding

function setFeeParameters(uint256 newFeeNumerator, address newfeeReceiverAddress)
        public
        onlyOwner
    {

Tools Used

Recommended Mitigation Steps

Some solutions include:

See also What is Centralization Risk?

c4-judge commented 1 year ago

0xean marked the issue as unsatisfactory: Insufficient quality