search

code-423n4 / 2023-02-gogopool-mitigation-contest-findings

0 stars 0 forks source link

Mitigation Confirmed for Mitigation of M-20 Issue mitigated #45

Open code423n4 opened 1 year ago

code423n4 commented 1 year ago

C4 issue

M-20: TokenggAVAX: maxDeposit and maxMint return wrong value when contract is paused

Comments

The contract TokenggAVAX was implemented as to the ERC-4626 spec, but a few important functions were not overridden, namely maxDeposit and maxMint. As a result the pausability of the protocol was not reflected for these functions and wrong values are returned.

Mitigation

PR #33 The relevant functions are overridden with correct logic for paused state. Double checked other ERC-4626 specs as well and it looks good.

Tests

Newly added relevant tests are checked. All passing - testMaxMint(), testMaxDeposit().

Conclusion

LGTM

c4-judge commented 1 year ago

GalloDaSballo marked the issue as satisfactory