Closed c4-judge closed 1 year ago
Judge has assessed an item in Issue #7 as 2 risk. The relevant finding follows:
L-01 changePayees() Suggest adding to check whether newPayees are duplicated to avoid _totalShares error
function changePayees(address[] calldata newPayees, uint256[] calldata newShares) external override onlyManager {
...
for (uint256 i; i < newPayees.length; i++) {
}
if (newPayees[i] == address(0)) { revert Errors.CANNOT_SET_TO_ADDRESS_ZERO(); } if (newShares[i] == 0) { revert Errors.SHARE_CANNOT_BE_ZERO(); } address payee = newPayees[i]; _payees.add(payee); _shares[payee] = newShares[i]; _totalShares += newShares[i]; emit PayeeAdded(payee, newShares[i]); }
GalloDaSballo marked the issue as duplicate of #13
GalloDaSballo marked the issue as satisfactory
Judge has assessed an item in Issue #7 as 2 risk. The relevant finding follows:
L-01 changePayees() Suggest adding to check whether newPayees are duplicated to avoid _totalShares error
...
}
}