search

code-423n4 / 2023-03-aragon-findings

0 stars 0 forks source link

Gas Optimizations #170

Open code423n4 opened 1 year ago

code423n4 commented 1 year ago

See the markdown file with the details of this report here.

c4-judge commented 1 year ago

0xean marked the issue as grade-a

novaknole20 commented 1 year ago
  1. you really don't gain any good gain with it and in the end, it's not worth it. Also, 95% Of these, they are upgradeable which means only one time deployment cost happens for implementation for these keccak256 and even if not, we prefer it this way.
  2. you don't gain much here at all. Winning 50 gas is something that we don't focus.
  3. This is test file, so not relevant.
  4. Not sure I get this, but still don't think it's relevant.
  5. framework is already complicated. We think this is not worth it. method id order could get you 50 gas gain which is negligible.
  6. same as above.
  7. ..
  8. ..
  9. ..
  10. True, let me give update on this tomorrow.
c4-sponsor commented 1 year ago

novaknole20 marked the issue as sponsor acknowledged