QA Report

[code423n4]

See the markdown file with the details of this report here.

[c4-judge]

0xean marked the issue as grade-b

[novaknole20]

[L-01] Add constructor initializers

We have a call to initialize() in the constructors in the contracts mentioned.

Disagree with this vuln

[novaknole20]

[L-02] initialize() function can be called by anybody

All functions listed are protected by the initializer or reinitialize modifier so that this function can only be called once or the n amount of times defined by the reinitialize modifier

Disagree with this vuln

[novaknole20]

[L-03] Lack of Input Validation

This function is inteded to be called from the PluginSetupProcessor and has no state modifying implications. Thus no gas wasting validation is needed.

Disagree with this vuln

[novaknole20]

[L-04] Loss of precision due to rounding

Yeah the ceiling functions we want to ceil or floor the number. The bitmap thingy is copied from Uniswap and works as intended.

Disagree with this vuln.

[novaknole20]

[N-01] NatSpec comments should be increased in contracts

Our documentation is generated based on the natspec comments. Without proper examples (excluding the testing and example contracts) I don't see space to improve them.

[novaknole20]

[N-02] Function writing that does not comply with the Solidity Style Guide

Yep we didn't follow fully the solidity coding guide lines

[novaknole20]

[N-03] Include return parameters in NatSpec comments

Same as N-01

[c4-sponsor]

novaknole20 requested judge review

[c4-sponsor]

novaknole20 marked the issue as sponsor disputed