search

code-423n4 / 2023-03-kuma-mitigation-contest-findings

0 stars 0 forks source link

Mitigation Confirmed for M-02 #13

Open code423n4 opened 1 year ago

code423n4 commented 1 year ago

The issue raised in M-02 is that KUMAFeeCollector.changePayees() would execute incorrectly if the their were duplicates in the newPayees array. This is fixed by reverting if _payees.add(payee) == false. _payees.add(payee) will return false if payee is already part of the set. Since _payees starts as a empty set the only way for the add to fail is if newPayees contains the same payee twice. As a result this causes changePayees to revert if it contains any duplicates, addressing the underlying issue.

c4-judge commented 1 year ago

GalloDaSballo marked the issue as satisfactory