code-423n4 / 2023-03-kuma-mitigation-contest-findings

0 stars 0 forks source link

Mitigation Confirmed for GAS #24

Open code423n4 opened 1 year ago

code423n4 commented 1 year ago

Gas Report Mitigation Review - Partially Alleviated

KBC-01G: Alleviated

The data location of the variable has been appropriately adjusted to calldata, optimizing its read-access gas cost.

KBC-02G: Alleviated

The variable declaration has been adjusted as advised.

KIB-01G: Alleviated

The redundant contract-level variable has been safely omitted from the codebase.

KIB-02G: Alleviated

All four instances of redundant self-calls have been safely replaced by internal calls.

KIB-03G: Not Alleviated

The KUMA Protocol team has opted not to apply this optimization to their codebase.

KAP-01G: Not Alleviated

The KUMA Protocol team has opted not to apply this optimization to their codebase.

KFC-01G: Not Alleviated

The KUMA Protocol team has opted not to apply this optimization to their codebase.

KFC-02G: Partially Alleviated

All but the first instance have been properly optimized, rendering this exhibit partially alleviated.

KFC-03G: Not Alleviated

The KUMA Protocol team has opted not to apply this optimization to their codebase.

KFC-04G: Alleviated

A local variable is now updated on each iteration with only a single storage update occurring after the for loop, optimizing the code as advised.

KFC-05G: Not Alleviated

The KUMA Protocol team has opted not to apply this optimization to their codebase.

KFC-06G: Not Alleviated

The KUMA Protocol team has opted not to apply this optimization to their codebase.

KSP-01G: Alleviated

The explicit function names have been removed as advised, optimizing the function's memory allocation.

KSP-02G: Alleviated

The loop limit evaluation is now cached to a local variable as advised, optimizing each iteration's gas cost.

KSP-03G: Not Alleviated

The KUMA Protocol team has opted not to apply this optimization to their codebase.

KYC-01G: Alleviated

The redundant overrides of individual functions were removed, instead overriding the _beforeTokenTransfer function optimally.

KBT-01G: Alleviated

The redundant overrides of individual functions were removed, instead overriding the _beforeTokenTransfer function optimally.

KBT-02G: Alleviated

The msg.sender statement is now in use throughout the contract, alleviating the inconsistency outlined by the exhibit.

MRF-01G: Not Alleviated

The KUMA Protocol team has opted not to apply this optimization to their codebase.

MRF-02G: Not Alleviated

The KUMA Protocol team has opted not to apply this optimization to their codebase.

MRF-03G: Not Alleviated

The KUMA Protocol team has opted not to apply this optimization to their codebase.

MAR-01G: Alleviated

The startedAt variable is now properly assigned to the _updatedAt value, ensuring that the function conforms closer to the Chainlink standard and does not yield empty variables.

c4-judge commented 1 year ago

GalloDaSballo marked the issue as satisfactory