code-423n4 / 2023-03-neotokyo-findings

4 stars 0 forks source link

Unvalidated input in setManagerRight function #436

Closed code423n4 closed 1 year ago

code423n4 commented 1 year ago

Lines of code

https://github.com/code-423n4/2023-03-neotokyo/blob/main/contracts/access/PermitControl.sol#L128

Vulnerability details

Impact

The setManagerRight function takes _managedRight and _managerRight as inputs without validating them This could potentially lead to unexpected results if the input values are not what the function expects.

Tools Used

Recommended Mitigation Steps

Provide parameters validation

c4-judge commented 1 year ago

hansfriese marked the issue as unsatisfactory: Out of scope