code-423n4 / 2023-03-zksync-findings

6 stars 1 forks source link

QA Report #115

Closed code423n4 closed 1 year ago

code423n4 commented 1 year ago

See the markdown file with the details of this report here.

GalloDaSballo commented 1 year ago

1. Use of deprecated storage variable in `L2EthToken` contract

Invalid as unused

2. Potential reentrancy vulnerability in `L2EthToken` contract

Invalid and lacking proof -5

3. Missing Input Validation in `SystemContext` contract

It may not be worth adding validation at this low level due to the massive overhead, I'm not awarding this in lack of nuance

4. Gas limit restriction in `precompileCall`

Invalid - 5

5. Lack of Input Validation in `SystemContractHelper` Library

6. Lack of input validation in `SystemContractHelper` library functions

7. Mismatch between unused parameters

8. Outdated compiler

Am closing as low quality, recommend you focus on accuracy

c4-judge commented 1 year ago

GalloDaSballo marked the issue as grade-c