search

code-423n4 / 2023-03-zksync-findings

5 stars 1 forks source link

QA Report #123

Closed code423n4 closed 1 year ago

code423n4 commented 1 year ago

See the markdown file with the details of this report here.

GalloDaSballo commented 1 year ago

[N-1] Signature malleability of EVM’S ecrecover()

Invalid, sponsor has added the check -3

[N-2] Large multiples of ten should use scientific notation rather than decimal literals, for readability

R

[N-3] Unused imports

NC

[N-4] Use require instead of assert

R

[N-5] Constant values such as a call to keccak256(), should used to immutable rather than constant

Disagree

[N-6] Stop using v != 27 && v != 28 or v == 27 || v == 28

R

[L-1] Non-library/interface files should use fixed compiler versions, not floating ones

NC

[L-2] Unused/Empty RECEIVE()/FALLBACK() function

Disputing for this case

GalloDaSballo commented 1 year ago

3R 2NC -3

c4-judge commented 1 year ago

GalloDaSballo marked the issue as grade-c