code-423n4 / 2023-03-zksync-findings

5 stars 1 forks source link

QA Report #162

Closed code423n4 closed 1 year ago

code423n4 commented 1 year ago

See the markdown file with the details of this report here.

GalloDaSballo commented 1 year ago

L-1 verifyingContract is not used Low 1 Invalid

NC-1 Order of Functions Non-Critical 7 NC

NC-2 Order of Layout Non-Critical 4 NC

NC-3 Missing leading underscores Non-Critical 10 NC

NC-4 Scientific notation may be used Non-Critical 1 R

NC-5 Unused named return variables Non-Critical 2 R

NC-6 Visibility is not set Non-Critical 4 NC

NC-7 Maximum line length exceeded Non-Critical 5 NC

GalloDaSballo commented 1 year ago

2R 5NC

c4-judge commented 1 year ago

GalloDaSballo marked the issue as grade-c