search

code-423n4 / 2023-03-zksync-findings

6 stars 1 forks source link

QA Report #168

Closed code423n4 closed 1 year ago

code423n4 commented 1 year ago

See the markdown file with the details of this report here.

GalloDaSballo commented 1 year ago

assert Used Over require R

Consider SafeCast Disputing as inaccurate, -3

Contracts Missing Full NatSpec Header NC

Inconsistent Named Returns R

Spelling Mistake NC

Underscore Notation Not Used or Not Used Consistently NC

bytes.concat() Can Be Used Over abi.encodePacked() NC

Space Between License and Pragma NC

Inconsistent Trailing Period NC

ERC20 Token Recovery Disputing due to lack of detail

Gas Greif If Relayed Disputing due to lack of nuance, target contract is known - 3

Lack of Interface NatSpec NC

Inconsistent NatSpec Style See above

NatSpec Comments Without Tag See above

Style Guide Violations See above

Maximum Line Length NC

Order of Functions NC

Whitespace in Expressions Disputing, the extra space is because they are ignoring a parameter, you always have a space after a comma

Function Declaration Style See above

Order of Layout See above

GalloDaSballo commented 1 year ago

Needs substance imo, this is a good base but it's not unique enough imo

c4-judge commented 1 year ago

GalloDaSballo marked the issue as grade-c