search

code-423n4 / 2023-03-zksync-findings

6 stars 1 forks source link

QA Report #169

Closed code423n4 closed 1 year ago

code423n4 commented 1 year ago

See the markdown file with the details of this report here.

GalloDaSballo commented 1 year ago

1 Potential risk of underflow in the withdraw function Low 1 Invalid

2 require should be used instead of assert NC 2 R

3 Avoid floating pragma where possible NC
NC

4 Related data should be grouped in a struct NC 2 Unsure about this one

5 public functions not called by the contract should be declared external instead NC 7 R

6 Missing natspec/comments NC

2R 2NC

c4-judge commented 1 year ago

GalloDaSballo marked the issue as grade-c