search

code-423n4 / 2023-03-zksync-findings

6 stars 1 forks source link

QA Report #175

Closed code423n4 closed 1 year ago

code423n4 commented 1 year ago

See the markdown file with the details of this report here.

GalloDaSballo commented 1 year ago

1 Use require rather than assert where appropriate 2 R

2 Upgrade Open Zeppelin contract dependency 3 R due to lack of explanations, consider filing a Med issue next time with a valid POC

1 Constant value definitions that include call to keccak256 should use immutable 2 Disputing as always

2 Avoid redundant return statement when function defines named return variable 1 R

3 Avoid extra-long single-line comments 14 NC

4 Improve unclear comments 2 NC

5 Typos 17 NC

6 Update sensitive terms in both comments and code 20 Disputing: https://eips.ethereum.org/EIPS/eip-4337

7 Upgrade pragma solidity version to latest version before finalization 3 NC

8-1 Natspec is partially missing for some functions 57 See 4

8-2 Natspec is wholly missing for some functions See 4

GalloDaSballo commented 1 year ago

3R 4NC

c4-judge commented 1 year ago

GalloDaSballo marked the issue as grade-c