search

code-423n4 / 2023-03-zksync-findings

6 stars 1 forks source link

QA Report #179

Closed code423n4 closed 1 year ago

code423n4 commented 1 year ago

See the markdown file with the details of this report here.

GalloDaSballo commented 1 year ago

[L-1]: Unsafe casting may overflow

Invalid because 2^20 is u160 so there is no risk of overflow

[N-1]: Function defines a named return variable but then it uses return statements

R

[N-2]: Use of immutable instead of constant keccak expression

Disputed

[N-3]: Follow Solidity standard naming conventions

NC

[N-4]: Wrong order of functions

NC

c4-judge commented 1 year ago

GalloDaSballo marked the issue as grade-c

GalloDaSballo commented 1 year ago

Needed a few more findings