search

code-423n4 / 2023-03-zksync-findings

5 stars 1 forks source link

QA Report #202

Closed code423n4 closed 1 year ago

code423n4 commented 1 year ago

See the markdown file with the details of this report here.

GalloDaSballo commented 1 year ago

[N-01] Redundant named returns

R

[N-02] Use of bytes.concat() instead of abi.encodePacked(,)

NC

[N-03] NON-LIBRARY/INTERFACE FILES SHOULD USE FIXED COMPILER VERSIONS, NOT FLOATING ONES

NC

[N-04] Function writing that does not comply with the Solidity Style Guide

NC

[N-05] USE UNDERSCORES FOR NUMBER LITERALS

R

[N-06] EXPRESSIONS FOR CONSTANT VALUES SUCH AS A CALL TO KECCAK256(), SHOULD USE IMMUTABLE RATHER THAN CONSTANT

Disagree

[N-07] USE REQUIRE INSTEAD OF ASSERT

R

[N-08] Using ecrecover is against best practice

Invalid, it's checked above

[N-09] Use a more recent pragma version

Invalid

[N-10] Constants should be defined rather than using magic numbers

Ignoring

GalloDaSballo commented 1 year ago

3R 3NC

c4-judge commented 1 year ago

GalloDaSballo marked the issue as grade-c