QA Report

[code423n4]

See the markdown file with the details of this report here.

[GalloDaSballo]

[N-01] legacy transactions is not correct, it should be EIP2930 transactions

NC

[N-02] require() should be used instead of assert()

R

[N-03] Require messages are too short and unclear

NC

[N-04] Duplicated require() checks should be refactored to a modifier :

R

[N-05] Adding a return statement when the function defines a named return variable, is redundant

R

[N-06] Typo ^0.8;

NC (as don't use floating pragma)

[N-07] Include return parameters in NatSpec comments

NC

[N-08] Use underscores for number literals

NC

[GalloDaSballo]

3R 4NC

[c4-judge]

GalloDaSballo marked the issue as grade-c