search

code-423n4 / 2023-04-caviar-findings

9 stars 4 forks source link

Upgraded Q -> 3 from #826 [1683219178977] #1003

Closed c4-judge closed 1 year ago

c4-judge commented 1 year ago

Judge has assessed an item in Issue #826 as 3 risk. The relevant finding follows:

  1. Consider using OpenZeppelin’s SafeCast library to prevent unexpected overflows when casting from uint256. PrivatePool.sol#L2 File: src/PrivatePool.sol

231: virtualNftReserves -= uint128(weightSum);

PrivatePoolMetadata.sol#L36 PrivatePoolMetadata.sol#L56 File: src/PrivatePoolMetadata.sol

36: PrivatePool privatePool = PrivatePool(payable(address(uint160(tokenId))));

56: PrivatePool privatePool = PrivatePool(payable(address(uint160(tokenId))));

c4-judge commented 1 year ago

GalloDaSballo marked the issue as duplicate of #167

c4-judge commented 1 year ago

GalloDaSballo marked the issue as satisfactory